Sweet - I got 2.2 working in the ancient Grafpup 1.04 just by installing it and gxmessage and GTKdialog3 and copying over a new version of find (you have to copy it at every boot because of the way Puppy 1.x uses unionfs)
N.B. that when I mention bugs and stuff below they are not specific to Puppy 1 - I would not report them if they were. They all show up in 2.16.
--------------------------------------
Here's a modified version of Pfind that I've done
Changes:
I added a "Show location" function, to open the location of the selected file in ROX.
I made double-clicking on a file open it by default in whatever way it would be opened if you double-clicked on it in ROX. (You can still add custom MIME-types for Pfind).
I added an "Open as text" function for the selected file.
I added a "Send to Trash" function for the selected file
I fixed gui spelling errors in what was line 462 of Pfind (advansed), and macthed or macthing or something somewhere
, and seperate in line 25 of pfind.txt
I modified line 4 of all the func_ files (and another line in func_run) so they handle files with spaces in the path correctly (please tell me if I'm misunderstanding something and shouldn't have done that).
------------------------------------
Further improvements I think could be made if anyone feels like it and can figure out how:
A "move file to..." feature would probably be fairly easy to do.
Ideally it might be good if the copy/link/rename dialogues could use the gtk dialogue that allows you to navigate directories - although in some ways I prefer the way it is done at the moment.
These improvements would probably have the most benefit to the end user:
How can we keep the Search Results window maximised when you click on a button to show only a certain type of file? Also, why (in JWM) when you first maximise it, does it maximise for a fraction of a second, then unmaximise, leaving a small gap at the top of the screen?
Can we do anything about the fact that when the file manager features are used (copy/link/delete), the results window goes back to showing all file types? (I'm wondering if they just need to be converted to the same format as the func_ files)
It would be good to have your previous search term stay in the search bar when you used advanced search, rather than
Code: Select all
func func_filter func_MIME func_openwith func_run func_tips func_viewfiles pfind tab130.png tab.png
--------------------------------------
Major Bugs (these are all there in 2.2 - not new in my version):
If you use advanced search and select an action other than show summary, it does not work correctly. Also the feature to find image files or music files etc does not seem to always work.
Once you have run a search, there is also a problem with instances of Pfind, Gtkdialog and gxmessage staying around after you close Pfind. If you kill some of them with kp before killing the Pfind instances, you get things happening again - new Pfind results windows popping up, music players opening to play lists - whatever you did before closing Pfind. So something clearly isn't exiting correctly. I read what Zigbert said about Gtkdialog above, but you also get instances of Pfind itself still there.
Minor Bugs:
If Pfind finds a large number of files (several thousand in Puppy 2.16, but several hundred in Grafpup 104 - that's how I noticed) then nothing shows up in the results pane. This does not appear consistent - sometimes it will show with more results than there are when it won't show other times. I guess maybe it is not actually the number of results, but something in the filenames or something.
I also have a strange situation where if I search for music files on one of my (FAT32) drives, it only shows me one file, but it plays all of them, except that Gxine complains that it can't play most of the mp3s in one particular folder. But it can normally play these files - very strange.
BTW the help states that it won't show results in file manager mode if some results have < or > in the path, but there must be another illegal character or something, as sometimes if you remove results with these, then it still won't show them in file manager mode.
BTW does anyone know what the deal is with the icons used in Pfind? Are they built in to gtkdialog3 or something? I can't find them. How can I get a copy of one?