pFilesearch 2.2

[disciple]

Also, if no files are found it displays a blank results window after the dialogue saying no files were found.
Personally I don't think these are important, because I don't think most people would want to use pfilesearch by itself at the moment as it only lists results as text... if only pfind had a --advanced option so we could launch it straight to the advanced search

[disciple]

Oh - I fount another bug: pfilesearch doesn't work properly if there is a "-" in the search text.

[zigbert]

Alister
Thanks for testing
I can't reproduce the bug when you use '-' in search text. Can you be more specific. It seems to work here.


Sigmund

[zigbert]

I also tested with a global search and got 126000 hits. They all showed up in the result window ???????


Sigmund

[disciple]

OK, my guess about it being to do with the number of hits must be wrong. I just tested again, and as an example, if I search for files with mp3 in their name on /mnt/sdb1, I get that error, but if I search for them in /mnt/sdb1/music, then it works... does the error message mean anything to you? Maybe it could be caused by invalid filenames or something weird...

pfilesearch doesn't work properly if there is a "-" in the search text.

I think this is only when searching for text in files. Actually, it is very inconsistent. I searched in a folder for files containing -hello, and got a list of false hits... I'm not sure what it actually searched for
On some searches I get a whole lot of

Code: Select all

grep: invalid max count

I don't know what it means.
On other searches it seems to hang - it never comes back with a results window, and when I use the cancel button it says in the terminal

Code: Select all

/usr/local/pfilesearch/box_splash: line 30: kill: (1404) - No such process

When I initially noticed a problem I had searched using pfind and the progress dialogue that says it is building a results list or something had a whole lot of those grep messages - but I can't replicate that now.

BTW have you considered adding to pfind and pfilesearch a dialogue that says "The search directory does not exist"? At the moment you just get told there were no files found, and it doesn't display the search path or anything, so you can't tell if you just typed a path wrong.
Actually, it would be cool if the error message and even the results window showed the find command

[disciple]

BTW this works in that drive - maybe when I get a chance I'll have to look at the find options pfilesearch uses and see if they work

Code: Select all

find /mnt/sdb1 -wholename *mp3

.
Good night

[zigbert]

Version 1.12
See main post

changelog
- Japanese translation. (thanks to himajin)
- Spanish translation (thanks to Proudog)
- Bugfix: Don't show result-window if no hits. (thanks to disciple)

[zigbert]

Version 1.13
See main post

Changelog
- Autodetection of all languages in ISO 639-1.
- Chinese translation. (thanks to sasaqqdan)
- Bugfix: support of pfind (4.8 ) -a option

[zigbert]

Version 1.14

changelog
- Bugfix: Find textstring containing 'A' 'N' or 'D'. (thanks to BarryK)

[disciple]

That sounds familiar... I wonder if it was also once a bug in pfind that got fixed before you invented pfilesearch

Re: the problem searching for text in files for a string that includes a - character:
If I search for -hell or -hello I get false hits. And I notice if I search for -spitfire I see error messages in the terminal from grep, saying that p is not a valid switch. So I suspect it is a problem with quoting the -

[disciple]

aha:

changelog 4.5
...
- Bugfix: Search in text (grep) failed when searchstring contained the letters A,D,N,O,R (thanks to disciple)

Better check if O and R are a problem here too maybe?

[zigbert]

changelog 4.5
...
- Bugfix: Search in text (grep) failed when searchstring contained the letters A,D,N,O,R (thanks to disciple)

Good catch. That fix wasn't complete. Let's hope I made it better this time.

Yes. it is obviously problems when searching for '-'. I'll look at it.


Sigmund

[zigbert]

Version 1.15

Changelog
- Bugfix: searching for text in files for a string that includes a - character (thanks to disciple)

[zigbert]

There still seems to be trouble wtih text search
I need more time

[zigbert]

Please test and report back

[zigbert]

Version 1.16

Fixes [AND] and [OR] for text search

[disciple]

Is it possible to exclude more than one directory from the search path? Because I couldn't figure out how
It would be nice to be able to exclude /proc, /sys, /initrd and /var

[zigbert]

Is it possible to exclude more than one directory from the search path? Because I couldn't figure out how
It would be nice to be able to exclude /proc, /sys, /initrd and /var

good suggestion.


Sigmund

[zigbert]

Version 1.17
See main post

This version search around 300% faster by default. - Only because /initrd is excluded by default.

Changelog
- Exclude /initrd by default
- Bugfix: Don't show excluded directory in hit-list

disciple
As far as I can find out - 'find' doesn't support several excluded directories.

[zigbert]

Version 1.18
See main post

changelog
- New parameter -t to define default search text
- Bugfix: -d parameter
- Bugfix: use [AND] in searchtext in combination with excluded item.